Make algorithms generic over IndexDistance #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airspeedswift
changed the title
airspeedswift
force-pushed
the
remove-indexdistance
branch
from
83ae317 to
b900eea
Compare
airspeedswift
force-pushed
the
remove-indexdistance
branch
from
b900eea to
0290cbd
Compare
|
@swift-ci please test |
|
Thanks! @swift-ci please smoke test |
aciidgh
approved these changes
Oct 28, 2017
aciidgh
reviewed
Oct 28, 2017
| guard i != j else { continue } | ||
| swap(&self[i], &self[j]) | ||
| let i = index(firstUnshuffled, offsetBy: numericCast(d)) | ||
| swapAt(firstUnshuffled, i) |
There was a problem hiding this comment.
we should update this as well https://github.com/apple/example-package-fisheryates/blob/master/Sources/FisherYates/Fisher-Yates_Shuffle.swift
There was a problem hiding this comment.
Thanks. I can do that one in a separate PR right?
There was a problem hiding this comment.
Yeah, its a separate repo anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR on the swift repo, swiftlang/swift#12641, attempts to remove
IndexDistance.SwiftPM currently has a couple of places where it constrains
IndexDistancetoInt. This PR changes those places to work with anyIndexDistanceso we can remove it on the swift repo without source-breaking SwiftPM.(we're working on the source compatibility story for this for other code outside swift-* stuff, but would be good to be able to test/land the change on master in the mean-time)