“Unhandled source” with no diagnostic

[dabrahams]

Description

Check out this tag. Note that swift test works fine. The two .testgen files should be reported as unhandled source files, but despite the lack of a plugins: declaration on the testTarget, are not.

Expected behavior

No response

Actual behavior

No response

Steps to reproduce

No response

Swift Package Manager version/commit hash

Swift Package Manager - Swift 5.8.0

Swift & OS version (output of swift --version ; uname -a)

swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-5.8.0.124.2 clang-1403.0.22.11.100)
Target: arm64-apple-macosx13.0
Darwin DaveA-MBP14.localdomain 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64

[tomerd]

cc @neonichu @abertelrud

[neonichu]

This is the output I see with main:

❯ swift test
warning: 'testgeneration': found 2 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
    /Users/neonacho/Desktop/TestGeneration/Tests/TestGenerationTests/second.testgen
    /Users/neonacho/Desktop/TestGeneration/Tests/TestGenerationTests/first.testgen
Building for debugging...
[3/3] Linking GenerateTests
Build complete! (6.18s)
Building for debugging...
[11/11] Linking TestGenerationPackageTests
Build complete! (21.59s)

[dabrahams]

OK, but I don't get to use main, do I? It's definitely not doing that in Swift 5.8. Maybe it's worth confirming that we know which change would have fixed this bug.

[dabrahams]

Also, when I use the nightly toolchain, even with what I presume is the fix for my error, I do get the "missing source" diagnostic:

xcrun --toolchain swift swift package clean && xcrun --toolchain swift swift test
warning: 'testgeneration': found 2 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
    /Users/dave/src/TestGeneration/Tests/TestGenerationTests/second.testgen
    /Users/dave/src/TestGeneration/Tests/TestGenerationTests/first.testgen
Building for debugging...
[1/3] Compiling GenerateTests GenerateTests.swift
[2/3] Emitting module GenerateTests
[2/3] Linking GenerateTests
Build complete! (11.66s)
[1/1] Compiling plugin TestGeneratorPlugin
Building for debugging...
[1/4] Generating GeneratedTests.swift
[3/8] Emitting module TestGeneration
[4/8] Compiling TestGeneration TestGeneration.swift
[5/11] Compiling GenerateTests GenerateTests.swift
[6/11] Emitting module GenerateTests
[6/11] Linking GenerateTests
[8/11] Compiling TestGenerationTests TestGenerationTests.swift
[9/11] Compiling TestGenerationTests GeneratedTests.swift
[10/11] Emitting module TestGenerationTests
[10/11] Linking TestGenerationPackageTests
Build complete! (31.89s)
Test Suite 'All tests' started at 2023-05-22 18:04:37.161
Test Suite 'TestGenerationPackageTests.xctest' started at 2023-05-22 18:04:37.162
Test Suite 'GeneratedTests' started at 2023-05-22 18:04:37.162
Test Case '-[TestGenerationTests.GeneratedTests test_first]' started.
Test Case '-[TestGenerationTests.GeneratedTests test_first]' passed (0.001 seconds).
Test Case '-[TestGenerationTests.GeneratedTests test_second]' started.
Test Case '-[TestGenerationTests.GeneratedTests test_second]' passed (0.000 seconds).

(the tests run regardless).