Skip to content

[OpenAPI] Document the Swiftly and SSWG APIs #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

czechboy0
Copy link
Member

@czechboy0 czechboy0 commented Jan 22, 2025

Motivation:

A new Swiftly releases API was added in #828, but that happened before the first OpenAPI PR landed in #841.

The /sswg/incubation/... API was also undocumented.

Modifications:

Add the Swiftly and SSWG APIs info into the existing OpenAPI doc, allowing Swiftly and other API adopters to generate their client.

Result:

Quicker, less error-prone integration with the Swift.org API from tools in the ecosystem.
Screenshot 2025-01-22 at 8 58 45 AM
Screenshot 2025-01-22 at 1 26 13 PM

@czechboy0
Copy link
Member Author

czechboy0 commented Jan 22, 2025

@cmcgee1024 I based it on your hand-crafted Codable types from https://github.com/swiftlang/swiftly/blob/c7fe40d3fd7d82f040014a88a11e8f6393e267d4/Sources/SwiftlyCore/HTTPClient.swift#L64, so should hopefully be plug-and-play for you now

@czechboy0 czechboy0 changed the title Add the new Swiftly API to the OpenAPI doc [OpenAPI] Document the Swiftly and SSWG APIs Jan 22, 2025
@czechboy0
Copy link
Member Author

cc @FranzBusch for the SSWG API

@FranzBusch
Copy link
Member

@0xTim Can you get this over the line for us?

@0xTim
Copy link
Member

0xTim commented Jan 22, 2025

@swift-ci test

@0xTim 0xTim enabled auto-merge (squash) January 22, 2025 12:40
@0xTim
Copy link
Member

0xTim commented Jan 22, 2025

@swift-ci please test

@0xTim 0xTim merged commit 4c14d38 into swiftlang:main Jan 22, 2025
1 check passed
@czechboy0 czechboy0 deleted the hd-add-swiftly-openapi branch January 22, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants