Add site governance process to contributing guidelines #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
requested review from
alexandersandberg,
daveverwer,
dempseyatgithub,
kaishin,
krstnfx,
mschinis,
shahmishal,
TimTr,
twostraws and
tomerd
as code owners
There was a problem hiding this comment.
Thanks for taking care of this, @0xTim! I left some comments. 🙂
tomerd
reviewed
May 31, 2022
tomerd
reviewed
May 31, 2022
tomerd
reviewed
May 31, 2022
kaishin
approved these changes
May 31, 2022
Co-authored-by: Reda Lemeden <git@redalemeden.com>
|
@swift-ci test |
shahmishal
reviewed
Jun 1, 2022
shahmishal
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
LGTM! Thanks @0xTim!
Agree with @alexandersandberg suggestion about including the forums.swift.org link in https://github.com/apple/swift-org-website/blob/008c6ed26996fec70965e378309a70bf0d730a3c/CONTRIBUTING.md?plain=1#L35
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the last meeting. Updates the contributing guidelines, PR and issue templates to point out the governance process for the site and blog posts