Update to Ruby 3.2 and latest Jekyll #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveverwer
requested review from
0xTim,
alexandersandberg,
dempseyatgithub,
parispittman,
kaishin,
mschinis,
shahmishal,
TimTr,
tomerd and
cthielen
as code owners
|
@swift-ci please test |
|
lgtm |
tomerd
approved these changes
Jul 31, 2023
0xTim
approved these changes
Jul 31, 2023
alexandersandberg
approved these changes
Aug 7, 2023
|
@shahmishal Are you happy with this? OK to merge? |
|
@swift-ci please test |
kaishin
approved these changes
Aug 15, 2023
shahmishal
approved these changes
Aug 29, 2023
|
@swift-ci test |
|
@swift-ci please test |
|
@shahmishal this came up again just now in #475. We should try and get this merged if possible. I just rebased it and did another |
|
Rebased once more for discussion at tonight's SWWG meeting. |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
daveverwer
commented
Jan 30, 2024
| @@ -85,7 +85,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| @media only screen and(max-width: 767px) { | |||
| @media only screen and (max-width: 767px) { | |||
There was a problem hiding this comment.
This whitespace is now required by the latest sass parser included with the latest Jekyll. See below for more instances of this.
|
@swift-ci please test |
|
@shahmishal over to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347
As Tim suggested here, this fixes the site build process when trying to use Ruby 3.2 to build it.
Gemfile.Dockerfileupdated to use Ruby 3.2 base image and latest Bundler version.