Add SSWG Update #28
Add SSWG Update #28
Conversation
0xTim
requested review from
amartini51,
airspeedswift,
hborla,
shahmishal,
TimTr,
tkremenek and
tomerd
as code owners
Co-authored-by: Mishal Shah <shahmishal@users.noreply.github.com>
_posts/2022-04-19-sswg-update.md
Outdated
|
|
||
| Since the last update from the SSWG, the Swift on Server ecosystem has continued to grow and expand. | ||
|
|
||
| To start, we are very happy to welcome three new members to the SSWG: |
There was a problem hiding this comment.
The context of "we" here is a bit unclear. Maybe:
To start, the SSWG is happy to welcome three new members:
That removes "we" entirely.
|
I just did another fresh read. One problem in the post it is keeps saying “we” without saying who “we” is. The post could be altered to not keep saying “we”, or it should clearly define who the “we” is at the start (i.e., the SSWG). |
|
@tkremenek OK, updated the post to remove all the first person stuff to make it clear |
Co-authored-by: Mishal Shah <shahmishal@users.noreply.github.com>
|
@tkremenek I've added links to everything and addressed the other comments |
_posts/2022-04-19-sswg-update.md
Outdated
|
|
||
| To start, the SSWG is very happy to welcome three new members: | ||
|
|
||
| Adam Fowler |
There was a problem hiding this comment.
How will these render? In the GitHub preview, these show as just a run of names on the same line. Do we need bullets here?
There was a problem hiding this comment.
I'd expect them to render all on one line as written, so bullets would be better.
There was a problem hiding this comment.
This is a copy paste error, fixed!
Looks great. I had only one remaining comment about the listing of new SSWG members. |
|
@shahmishal do we already have the capability to show a rendered version of the website from a PR? @0xTim if not, please run locally and attach a screenshot? |
No, this is not supported. |
|
@tomerd here you go |
|
This looks great to me. I suggest we wait until after the weekend to post. |
|
thanks @0xTim @cthielen and @tkremenek will merge Monday unless I hear otherwise |
_posts/2022-04-19-sswg-update.md
Outdated
| --- | ||
| layout: post | ||
| published: true | ||
| date: 2022-04-19 11:00:00 |
There was a problem hiding this comment.
This needs to be updated to today's date.
|
@swift-ci test |
Add's a blog post for the SSWG's Annual Update