Fix quoted home in swiftly install snippets #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
justice-adams-apple
approved these changes
Jun 13, 2025
shahmishal
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swiftly install snippets with the new website design are quoting the source of the
env.shscript. Inside, there is a
~character that represents the home directory. Since it is insidequotes this is not interpreted by the shell. It fails to find a directory called
~in the currentdirectory and swiftly isn't added to the PATH. The subsequent rehash is never run either.
Motivation:
Let's improve the initial user experience by fixing the failure.
Modifications:
Use the
$HOMEenvironment variable inside the quoted string instead of~so that it gets interpolated.Result:
The instructions should be runnable by new users again.