Fix VSCode Post Video #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
requested review from
alexandersandberg,
daveverwer,
dempseyatgithub,
kaishin,
krstnfx,
mschinis,
shahmishal,
TimTr,
twostraws and
tomerd
as code owners
|
@swift-ci test |
alexandersandberg
approved these changes
Jul 16, 2022
There was a problem hiding this comment.
Looks good to me. 👍 The quality is slightly lower with the GIF, but I think it's fine.
An alternative is using a video tag with muted and autoplay properties.
<video muted autoplay>
<source src="{{ site.baseurl }}/assets/images/vscode-extension-blog/symbol-completion.mp4">
</video>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VSCode Blog Post has a video pulled in via the markdown image tab. Only Safari supports loading videos via the image tab, so this converts it to a GIF so it works in all browsers