-
Notifications
You must be signed in to change notification settings - Fork 243
Add preceding newlines before Doxygen commands #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preceding newlines before Doxygen commands #237
Conversation
|
@swift-ci please test |
|
@Kyle-Ye @d-ronnqvist @QuietMisdreavus Can someone please assist with the review here? We need this for implementing signature help in SourceKit-LSP. Thanks in advance. 🙏🏼 |
|
@d-ronnqvist I'd appreciate your input on whether we should always use 2 separating lines or not. 🙏🏼 |
|
Hello @d-ronnqvist! Sorry for being noisy, but can you please recheck and let me know what the best course of action here is? 🙏🏼 |
c7d7a40 to
0ab83e3
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Hello @d-ronnqvist @QuietMisdreavus! Have you got a chance to check the updated changes? |
|
@QuietMisdreavus @d-ronnqvist Friendly reminder. |
QuietMisdreavus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for reworking it!
|
There's a command-line tool that exposes a hook to |
Summary
Formatting for Doxygen commands doesn't add preceding newlines to separate them from other markdown content.
Consider the below markdown:
Which when parsed with
.parseMinimalDoxygenproduces the following document structure:If we format that document with the default options, the resulting markdown is this:
Notice that everything is just once paragraph now which doesn't resemble the initial document.
Instead, we should separate Doxygen commands from other content similar to what's currently done by adding 2 newlines before a
Paragraph.Testing
Here's a simple reproducible example:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded