Remove -incremental when using -whole-module-optimization #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please smoke test |
keith
added a commit
to keith/swift-llbuild
that referenced
this pull request
Jul 19, 2023
Passing both results in noisy remarks when building from the command line like: ``` remark: Incremental compilation has been disabled: it is not compatible with whole module optimization ``` https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092 (cherry picked from commit 0c2e0dd / swiftlang#884)
|
a cherry pick for this too #885 |
dmbryson
approved these changes
Jul 19, 2023
keith
force-pushed
the
ks/remove-incremental-when-using-whole-module-optimization
branch
from
0c2e0dd
to
b017cca
Compare
keith
added a commit
to keith/swift-llbuild
that referenced
this pull request
Jul 19, 2023
Passing both results in noisy remarks when building from the command line like: ``` remark: Incremental compilation has been disabled: it is not compatible with whole module optimization ``` https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092 (cherry picked from commit 0c2e0dd / swiftlang#884)
|
@swift-ci please smoke test |
|
Looks like there are more tests you will have to modify. |
Passing both results in noisy remarks when building from the command line like: ``` remark: Incremental compilation has been disabled: it is not compatible with whole module optimization ``` https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092
keith
force-pushed
the
ks/remove-incremental-when-using-whole-module-optimization
branch
from
b017cca
to
d68c791
Compare
keith
added a commit
to keith/swift-llbuild
that referenced
this pull request
Jul 20, 2023
Passing both results in noisy remarks when building from the command line like: ``` remark: Incremental compilation has been disabled: it is not compatible with whole module optimization ``` https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092 (cherry picked from commit 0c2e0dd / swiftlang#884)
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
Green now! #885 too |
dmbryson
pushed a commit
that referenced
this pull request
Jul 26, 2023
Passing both results in noisy remarks when building from the command line like: ``` remark: Incremental compilation has been disabled: it is not compatible with whole module optimization ``` https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092 (cherry picked from commit 0c2e0dd / #884)
|
Thanks! |
keith
deleted the
ks/remove-incremental-when-using-whole-module-optimization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing both results in noisy remarks when building from the command line like:
https://forums.swift.org/t/incremental-compilation-has-been-disabled-it-is-not-compatible-with-whole-module-optimization/66092