Various set of SPM based build updates for Windows #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behaviour in CMake where we now build libllbuild statically and internalise it into llbuildSwift.
|
@swift-ci please test |
The set of libraries that use LLVM indirectly has shifted over the time that the initial SPM build for Windows was put together. Update the list to match the current reality.
This replicates the warning suppression flags from LLVM (and CMake) into the SPM based build. This should silence a significant portion of the warnings that we encounter when building with SPM.
We would previously reset the C++ settings rather than augmenting which would result in having to recreate any settings that were previously applied.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
johari
approved these changes
Mar 28, 2023
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the build for Windows to get SPM based builds working better. This should make it easier to work with llbuild and SPM when developing with SPM.