[LSP] Print LSP output as ASCII #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sys.stdout` seems to be `ascii` on some configurations, eg. Jenkins. When the string has UTF8 characters, this results in: ``` UnicodeEncodeError: 'ascii' codec can't encode character... ``` The output here is really just for debugging test failures, so just encode the string as ASCII and output that instead. Resolves rdar://105608805.
|
I can't reproduce this locally, so I assume the default encoding for Jenkin's console is 'ascii' rather than 'utf-8'. This is only failing on rebranch, presumably clangd is now outputting a unicode character where it wasn't before. |
|
We hit unrelated failures, I'm just going to merge. |
Well. That was a mistake. Should have just re-run - I missed a closing paren when I was moving this change over from the VM I was testing in. Fixed in #107 (FWIW Windows passed so I assumed it would be fine since it wasn't a platform specific change, but turns out we don't run these for Windows) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys.stdoutseems to beasciion some configurations, eg. Jenkins. When the string has UTF8 characters, this results in:The output here is really just for debugging test failures, so just encode the string as ASCII and output that instead.
Resolves rdar://105608805.