Skip to content

[icu] not building BUILD_DATA should still have an install target #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

[icu] not building BUILD_DATA should still have an install target #289

merged 1 commit into from
May 7, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented May 7, 2024

Also, validate it's set before checking it.

@hyp
[icu] not building BUILD_DATA should still have an install target
4c12ddf 
Also, validate it's set before checking it.
@hyp hyp requested review from shahmishal, tomerd and compnerd as code owners May 7, 2024 20:30
@hyp hyp merged commit 45a5c45 into main May 7, 2024
@hyp hyp deleted the eng/BUILD_DATA_fix branch May 7, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @compnerd