Concurrency-Safe Notifications #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to better explain Message/Notification conversion
cthielen
force-pushed
the
cthielen/notification-proposal
branch
from
6905774 to
d45df0c
Compare
cthielen
force-pushed
the
cthielen/notification-proposal
branch
from
fb8592c to
3205afd
Compare
…kup, and provide a default value for Message.name.
iCharlesHu
approved these changes
Nov 9, 2024
FranzBusch
reviewed
Nov 11, 2024
| static func makeNotification(_ message: Self) -> Notification | ||
| } | ||
|
|
||
| public protocol MainActorMessage: Message {} |
There was a problem hiding this comment.
I am wondering if this protocol should have a @MainActor annotation. Those types will only be sent and received from the MainActor anyways.
| ```swift | ||
| @available(FoundationPreview 0.5, *) | ||
| extension NotificationCenter { | ||
| public func addObserver<I: MessageIdentifier, M: AsyncMessage>(of subject: M.Subject, |
There was a problem hiding this comment.
How can those methods take an async closure while not being async themselves? Where is the task spawned that calls the observer closures?
If the addObserver method takes an async closure I would have expected that method to become async itself. Something more like this
await center.observe(of: subject, for: identifier) { message
// do something async with the message
await process(message)
}
This way you also don't need ObservationTokens but can just rely on task cancellation which IMO fits better into the Concurrency paradigms.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a proposal for adopting Swift Concurrency in
NotificationCenter.