Skip to content

Update wording and link in evolution.md #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

lamtrinhdev
Copy link
Contributor

@lamtrinhdev lamtrinhdev commented Aug 2, 2024

  • Update the wording from other API to other APIs.
  • Update the link of swift-evolution.

Correct typo comment from "resovled" to "resolved" at URL.swift
Update from `other API`to `other APIs`
@lamtrinhdev
Copy link
Contributor Author

lamtrinhdev commented Aug 2, 2024

Dear @parkera ,

Sorry for tagging you (because I see you are the last change of this file). I have a minor update for wording and link. Please help me to review it.

Thanks,
Lam

@lamtrinhdev lamtrinhdev changed the title Update wording in evolution.md Update wording and link in evolution.md Aug 2, 2024
Update the link.
@jmschonfeld
Copy link
Contributor

@swift-ci please test

@@ -1,6 +1,6 @@
# Foundation Evolution Process

All new public types, functions, and other API must go through an API review process. Foundation uses an API process inspired by the [Swift Evolution review process](https://github.com/apple/swift-evolution/blob/main/process.md).
All new public types, functions, and other APIs must go through an API review process. Foundation uses an API process inspired by the [Swift Evolution review process](https://github.com/swiftlang/swift-evolution/blob/main/process.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve always considered API to be the same “word”, singular or plural. However I am unsure if we have any consistency around this in the READMEs here, or other documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @parkera ,

Thank you for your feedback. As I refer at https://developer.apple.com and https://www.swift.org . They are using APIs.

This is just a minor update. If I am wrong, please support me to close this ticket.

Thanks,
Lam

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @parkera ,

How do you feel about this? If this does not make sense, we will close the ticket.

Thanks,
Lam

@parkera parkera merged commit 83d4538 into swiftlang:main Aug 20, 2024
3 checks passed
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
* Update URL.swift

Correct typo comment from "resovled" to "resolved" at URL.swift

* Update Evolution.md

Update from `other API`to `other APIs`

* Update Evolution.md

Update the link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants