[CMake] Fix macro install rpath #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jmschonfeld
force-pushed
the
cmake/fix-macro-rpath
branch
from
7583081 to
fc2871f
Compare
|
@swift-ci please test |
|
Full swift toolchain build passed with this change (and passed the rpath packaging tests too) |
iCharlesHu
approved these changes
Jul 29, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Jul 29, 2024
jmschonfeld
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the macro library's rpath to reference the correct locations for the host and stldib libraries that it depends upon. This matches the rpath values for the existing macro libraries:
I confirmed that using a locally built
libFoundationMacros.sowith this change successfully finds the required libraries rather than erroring out withcompiler plugin '/usr/lib/swift/host/plugins/libFoundationMacros.so' could not be loaded; libswift_StringProcessing.so: cannot open shared object file: No such file or directorylike before