Add SPI imports for SwiftCorelibsFoundation usage of Decimal #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds some tests for the exported functionality that SCL-F uses.
|
@swift-ci test |
iCharlesHu
approved these changes
Jul 19, 2024
iCharlesHu
reviewed
Jul 19, 2024
| @@ -14,6 +14,130 @@ | |||
| internal import _ForSwiftFoundation | |||
| #endif // FOUNDATION_FRAMEWORK | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Are we leaving these as comments intentionally?
There was a problem hiding this comment.
Nope, thanks. Will fix.
parkera
force-pushed
the
parkera/scl-f-decimal-additions
branch
from
0c7ce6d to
4191b7e
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some tests for the exported functionality that SCL-F uses.