Skip to content

[CMake] Disable macros in Windows CMake build #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jmschonfeld
Copy link
Contributor

The macro can only be built for the host architecture (since that's where it runs and that's what the SwiftSyntax dependency is built for). This works on Linux because the host architecture is always the same as the architecture for which we build Foundation. However, when building the Windows toolchain, Foundation is built for a variety of architectures that may include those that are not the same as the host. In the fullness of time, we need to ensure the macros only build for the host architecture (either by splitting it out into a separate, single CMake invocation or by providing the architecture to the cmake build to override for the macro target). But in the short term, to unblock merging the Foundation re-core, this disables the macro on Windows toolchain builds to keep the ball rolling. I'll revisit this once we get a toolchain going to see how we can add this back in. As it stands today, nothing in the toolchain relies on the macro (beyond unit tests) so this is ok to leave out for the interim.

@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld
Copy link
Contributor Author

This allowed the Windows toolchain build to get a decent bit farther, merging to keep making forward progress there

@jmschonfeld jmschonfeld merged commit 9a44043 into swiftlang:main Jun 27, 2024
2 checks passed
@jmschonfeld jmschonfeld deleted the cmake/disable-macro-windows branch June 27, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants