Update remaining Predicate tests to use the #Predicate macro #299
Conversation
|
@swift-ci please test |
| #if !FOUNDATION_FRAMEWORK | ||
| // Resolve ambiguity between Foundation.#Predicate and FoundationEssentials.#Predicate | ||
| @freestanding(expression) | ||
| @available(macOS 14, iOS 17, tvOS 17, watchOS 10, *) | ||
| macro Predicate<each Input>(_ body: (repeat each Input) -> Bool) -> Predicate<repeat each Input> = #externalMacro(module: "FoundationMacros", type: "PredicateMacro") | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Sigh... we can't switch to swift-testing fast enough.. do we have to do this for every test file?
There was a problem hiding this comment.
Luckily this is the only file that uses this macro (in non-FOUNDATION_FRAMEWORK code) so at least for now it's a non-issue, and I think it still might work in other files too (since the macro's visibility is internal) but I'm not certain
|
Looks like the usage of the macro triggered a compiler crash. That crash should be resolved by swiftlang/swift-syntax#2312 (since similar crashes were successfully resolved by a similar change for SwiftPM plugins) so I'll hang onto this until a snapshot with the swift-syntax fix lands |
|
We've determined that the Linux CI failure is indeed due to this swift-syntax issue, and is affecting the |
This updates the last of the predicate tests to use
#Predicateinstead of manual construction and removes the windows restrictions for usage of the macro