Skip to content

[wasm] Stop requiring TZDIR and TZDEFAULT on WASI #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Apr 14, 2025

Those constants are not used on WASI in Swift side, so there's no need to require them in the C headers. The #error was introduced by 03fe46f.

Those constants are not used on WASI in Swift side, so there's no
need to require them in the C headers.
@kateinoigakukun
Copy link
Member Author

@swift-ci test

@parkera
Copy link
Contributor

parkera commented Apr 14, 2025

#elseif os(WASI)
            // WASI doesn't provide a way to get the current timezone for now, so
            // just return the default GMT timezone.

I guess time zones just don't exist in this environment?

@kateinoigakukun
Copy link
Member Author

Yes, the platform doesn't have the time zone concept.

@parkera parkera merged commit 99c5c0c into swiftlang:main Apr 14, 2025
3 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/fix-tzdir-wasi branch April 15, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants