Add an upcall point to swift-corelibs-foundation for String encoding conversion #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Will, of course, need a follow up in swift-corelibs-foundation to replace the function with one that calls into |
jmschonfeld
reviewed
Mar 19, 2025
|
|
||
| #if !FOUNDATION_FRAMEWORK | ||
| @_spi(SwiftCorelibsFoundation) | ||
| dynamic public func _cfStringEncodingConvert(string: String, using encoding: UInt, allowLossyConversion: Bool) -> Data? { |
There was a problem hiding this comment.
Should we add a similar up-call for the bytes --> String direction so that we support decoding as well?
|
@swift-ci test |
jmschonfeld
approved these changes
Mar 19, 2025
|
@swift-ci test |
YOCKOW
added a commit
to YOCKOW/swift-foundation
that referenced
this pull request
Jun 17, 2025
Links: - Issue: swiftlang#1015 - Resolvers: * swiftlang#1217 * swiftlang/swift-corelibs-foundation#5194
YOCKOW
added a commit
to YOCKOW/swift-foundation
that referenced
this pull request
Aug 18, 2025
Links: - Issue: swiftlang#1015 - Resolvers: * swiftlang#1217 * swiftlang/swift-corelibs-foundation#5194
itingliu
pushed a commit
that referenced
this pull request
Sep 4, 2025
* [Proposal] Add "String Encoding Names" proposal. This proposal allows `String.Encoding` to be converted to and from various names. For example: ```swift print(String.Encoding.utf8.ianaName!) // Prints "UTF-8" print(String.Encoding(ianaName: "ISO_646.irv:1991") == .ascii) // Prints "true" ``` * Change the link to implementation. * Remove description about #1015 since it is resolved. Links: - Issue: #1015 - Resolvers: * #1217 * swiftlang/swift-corelibs-foundation#5194 * Add a description about already-available ICU string converter.
itingliu
pushed a commit
that referenced
this pull request
Sep 16, 2025
* [Proposal] Add "String Encoding Names" proposal. This proposal allows `String.Encoding` to be converted to and from various names. For example: ```swift print(String.Encoding.utf8.ianaName!) // Prints "UTF-8" print(String.Encoding(ianaName: "ISO_646.irv:1991") == .ascii) // Prints "true" ``` * Change the link to implementation. * Remove description about #1015 since it is resolved. Links: - Issue: #1015 - Resolvers: * #1217 * swiftlang/swift-corelibs-foundation#5194 * Add a description about already-available ICU string converter. * SF-0033: Add `@available` attributes to sample code. In response to: https://forums.swift.org/t/review-sf-0033-string-encoding-names/81965/7 * SF-0033: Clarify which "case-insensitivity" is used. In response to: https://forums.swift.org/t/review-sf-0033-string-encoding-names/81965/8 * SF-0033: Change FoundationPreview version to 6.3. In response to: #1502 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an upcall to swift-corelibs-foundation for converting String encodings that swift-foundation does not implement.
Partially resolves #1216.