Don't encode colon if URLComponents path starts with colon #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Jan 24, 2025
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Mar 5, 2025
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Mar 5, 2025
parkera
pushed a commit
that referenced
this pull request
Mar 5, 2025
* (141549683) Restore behavior of URL(string: "") returning nil (#1103) * (142076445) Allow URL.standardized to return an empty string URL (#1110) * (142076445) Allow URL.standardized to return an empty string URL * Add ?? self to prevent force-unwrap * (142446243) Compatibility behaviors for Swift URL (#1113) * (142589056) URLComponents.string should percent-encode colons in first path segment if needed (#1117) * (142667792) URL.absoluteString crashes if baseURL starts with colon (#1119) * (143159003) Don't encode colon if URLComponents path starts with colon (#1139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps can take a URL string like
which
URLnow allows (after the compatibility change to go back to allowing an empty scheme), and pass it toURLComponents(string:).URLComponentsfollows RFC 3986, which says a scheme cannot be empty, so it interprets the whole string as a path. The app could then usecomponents.queryItems = ...to assign query items and callcomponents.url, which needs to generate the new.string.During string generation,
URLComponentspercent encodes the colon at the beginning of the path, so theURLreturned does not have the scheme, host, and path it started out with. We can fix this by not percent-encoding any colons in the first path segment if the colon is the first character in the string.This still preserves the behaviors of both
URLandURLComponents:URLcan interpret the colon as an empty scheme like before, andURLComponents, knowing that a scheme cannot be empty according to RFC 3986, can still interpret the string as a relative path.