Skip to content

Add compatibility check for malformed URL(filePath:) input #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add compatibility check for malformed URL(filePath:) input #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Sources/FoundationEssentials/URL/URL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,6 +2239,17 @@ extension URL {
var filePath = path
#endif

#if FOUNDATION_FRAMEWORK
// Linked-on-or-after check for apps which incorrectly pass a full
// "file:" URL string. In the old implementation, this could work
// rarely if the app immediately called .appendingPathComponent(_:),
// which used to accidentally interpret a relative string starting
// with "file:" as an absolute file URL string.
if Self.compatibility3 && filePath.starts(with: "file:") {
filePath = String(filePath.dropFirst(5))
}
#endif

let isAbsolute = URL.isAbsolute(standardizing: &filePath)

#if !NO_FILESYSTEM
Expand Down