Restore URL.host bracket stripping for compatibility
#1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Oct 25, 2024
|
Should cherry pick for release/6.0 |
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Oct 29, 2024
jrflat
added a commit
that referenced
this pull request
Nov 4, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the new Swift
URLimplementation, we unifiedURL.hostto behave likeURLComponents.host, which will return an IP literal with the square brackets included. While RFC 3986 does say thathostincludes these square brackets, this change caused bincompat issues for clients who take IPv6 addresses fromURL.hostand pass them directly to APIs likeinet_pton(3).Because
URL.hosthas long behaved by stripping the brackets, and no longer stripping them can cause immediate client breakage that requires workaround, this PR restores the previous behavior. Thank you to all who worked around it for the time being.Resolves #957