(133301930) Bridging NSURLComponents to URLComponents loses percent-encoding (#831)

Author: jrflat

Sources/FoundationEssentials/URL/URLComponents.swift

@@ -1141,15 +1141,19 @@ extension URLComponents: ReferenceConvertible, _ObjectiveCBridgeable {
     }
 
     public static func _conditionallyBridgeFromObjectiveC(_ x: NSURLComponents, result: inout URLComponents?) -> Bool {
+        if let swiftComp = x as? _NSSwiftURLComponents {
+            result = swiftComp.components
+            return true
+        }
         var comp = URLComponents()
         comp.scheme = x.scheme
-        comp.user = x.user
-        comp.password = x.password
-        comp.host = x.host
+        comp.percentEncodedUser = x.percentEncodedUser
+        comp.percentEncodedPassword = x.percentEncodedPassword
+        comp.encodedHost = x.encodedHost
         comp.port = x.port?.intValue
-        comp.path = x.path ?? ""
-        comp.query = x.query
-        comp.fragment = x.fragment
+        comp.percentEncodedPath = x.percentEncodedPath ?? ""
+        comp.percentEncodedQuery = x.percentEncodedQuery
+        comp.percentEncodedFragment = x.percentEncodedFragment
         result = comp
         return true
     }

Tests/FoundationEssentialsTests/URLTests.swift

@@ -1082,4 +1082,20 @@ final class URLTests : XCTestCase {
         XCTAssertEqual(comp.percentEncodedPath, "/my%00path")
         XCTAssertEqual(comp.path, "/my\u{0}path")
     }
+
+#if FOUNDATION_FRAMEWORK
+    func testURLComponentsBridging() {
+        var nsURLComponents = NSURLComponents(
+            string: "https://example.com?url=https%3A%2F%2Fapple.com"
+        )!
+        var urlComponents = nsURLComponents as URLComponents
+        XCTAssertEqual(urlComponents.string, nsURLComponents.string)
+
+        urlComponents = URLComponents(
+            string: "https://example.com?url=https%3A%2F%2Fapple.com"
+        )!
+        nsURLComponents = urlComponents as NSURLComponents
+        XCTAssertEqual(urlComponents.string, nsURLComponents.string)
+    }
+#endif
 }