Fix NSURLComponents bridging with percent-encoding #831
+26
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #828 (thanks @giginet for filing!)
Because the bridging code assigns non-percentEncoded variants of the components (e.g.
.path
instead of.percentEncodedPath
), anNSURLComponents
that is bridged to SwiftURLComponents
loses its percent-encoding. For example:Note we only lose percent-encoding if the percent-encoding is not absolutely required, e.g.
"://"
does not require encoding in the query component, but this is something we should fix regardless.This PR first checks if we can cast the
NSURLComponents
to a_NSSwiftURLComponents
and take the components right out of it. If the cast fails, we fall back to assigning thepercentEncoded
properties.