Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure there is a break after an #endif. #729

Merged
merged 1 commit into from
May 2, 2024

Conversation

shawnhyam
Copy link
Contributor

You wouldn't normally allow a line break just before the comma in a parameter list, but if the preceding line is an #endif, we have to be sure to include the break or we'll generate invalid code. Fix #705.

You wouldn't normally allow a line break just before the comma in a
parameter list, but if the preceding line is an #endif, we have to
include the break or we'll generate invalid code.
@allevato
Copy link
Member

allevato commented May 2, 2024

Wow, I guess I've never used postfix-#if in a comma-delimited list before; having to put a newline before the comma is super unfortunate 😞 Thanks for the fix!

@allevato allevato merged commit bc7c751 into swiftlang:main May 2, 2024
@shawnhyam shawnhyam deleted the fix-arguments-following-endif branch May 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect formatting for arguments following postfix #if
2 participants