Skip to content

Fix swift-format In Response to SwiftSyntax Changes #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 22, 2022

There's been a bit of churn in the mainline of swift-syntax lately which has broken swift-format. Repair the build.

@CodaFi CodaFi requested a review from allevato July 22, 2022 22:55
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've been mostly off the grid for several days.

Thanks for doing this update! This all looks good; I don't currently have access to my workstation to do any testing of my own, so as long as all the tests pass against a recent development snapshot, feel free to merge it.

@allevato
Copy link
Member

allevato commented Aug 2, 2022

I had a chance to test this and everything passes except for two tests that are fixed by #385 and #386 (which apparently I uploaded back in June but never created the PRs for). So I'll go ahead and merge this along with those two. Thanks again!

@allevato allevato merged commit 0349863 into swiftlang:main Aug 2, 2022
@CodaFi CodaFi deleted the in-peak-format branch August 18, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants