Add support for color diagnostics. #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the diagnostic printer will detect whether stderr is connected to a TTY and use ANSI color sequences if so. We use the same colors that `swiftc` uses for its diagnostics: white for the main text, red for error labels, magenta for warning labels, and gray for note labels. Additionally, we use yellow to emphasize the finding category for diagnostics that come from linter findings. This behavior can be controlled manually using the `--color-diagnostics/--no-color-diagnostics` flag pair.
Member
Author
|
cc @dylansturg |
dylansturg
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the diagnostic printer will detect whether stderr is
connected to a TTY and use ANSI color sequences if so. We use the
same colors that
swiftcuses for its diagnostics: white for themain text, red for error labels, magenta for warning labels, and
gray for note labels. Additionally, we use yellow to emphasize the
finding category for diagnostics that come from linter findings.
This behavior can be controlled manually using the
--color-diagnostics/--no-color-diagnosticsflag pair.