Revise SE-0542 - #3404
Conversation
d916946 to
e0c726d
Compare
f5f5ee0 to
49a72cd
Compare
benrimmington
left a comment
There was a problem hiding this comment.
@clive819 I don't think proposal filenames should be changed, because any links in the forums (or elsewhere) will be broken. There isn't an automatic redirection, unlike repository renames.
For example, the proposal for InlineArray is still named 0453-vector.md.
The only counterexample I can find is when 0519-borrow-inout-types.md was renamed to 0519-ref-mutableref-types.md. But that required a hard-coded workaround in swiftlang/swift-evolution-metadata-extractor#106.
Yes, the name of the file should be kept the same. The counterexample cited (SE-0519) needed to be special-cased in the swift-evolution-metadata-extractor tool to ignore the now-incorrect file. (For over a decade it has been an invariant that each proposal number has a single markdown file, and that invariant is relied on. From an automatic processing perspective, it would be much better for that to be a very rare exception as opposed to a common case which adds additional complexity for very little seeming benefit.) The name of the file does not need to exactly match the title of the proposal. People generally read the proposal title not the file name, allowing flexibility in renaming the title without having to rename the file. |
Address comments in https://forums.swift.org/t/se-0542-package-manager-condition-plugins/88820