Implement swift_build_sdk_interfaces.py using libSwiftDriver #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| } | ||
|
|
||
| func addCommonFlags(commandLine: inout [Job.ArgTemplate]) { | ||
| commandLine.appendFlag(.buildModuleFromParseableInterface) |
There was a problem hiding this comment.
tiny nitpick: the current version of this is compile-module-from-interface
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
3 times, most recently
from
af4afcb to
73d943a
Compare
artemcm
reviewed
Apr 5, 2021
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
2 times, most recently
from
816d5b9 to
8ec2adb
Compare
artemcm
approved these changes
Apr 5, 2021
artemcm
approved these changes
Apr 5, 2021
| @@ -21,6 +21,9 @@ let package = Package( | |||
| .executable( | |||
| name: "swift-help", | |||
| targets: ["swift-help"]), | |||
| .executable( | |||
| name: "swift-build-sdk-interfaces", | |||
There was a problem hiding this comment.
I think some changes in build-script-helper.py are required to make sure this gets installed when built with build-script.
There was a problem hiding this comment.
Yeah, will make those build-script/cmake changes later.
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
4 times, most recently
from
48326b9 to
e0caa90
Compare
artemcm
reviewed
Apr 7, 2021
artemcm
reviewed
Apr 7, 2021
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
4 times, most recently
from
a9ab8af to
007cb7a
Compare
|
@swift-ci please test |
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
from
007cb7a to
20e570d
Compare
|
@swift-ci please test |
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
2 times, most recently
from
881ebf1 to
2e34250
Compare
This PR is an implementation of swift_build_sdk_interfaces.py using libSwiftDriver. The tool is used to traverse an entire SDK to find Swift interface files and to generate prebuilt module cache for each one of them. Comparing to the python implementation, this implementation generates the prebuilt modules in the dependency order so that: (1) It's more performant than the python counterpart. Several preliminary experiments showed an average of 40% less CPU time spent on generating modules in an SDK. (2) It fails fast. If an interface is broken in the SDK, this new implementation won't schedule jobs for building other modules depending on this interface. It should help us avoid issues like rdar://76201633
nkcsgexi
force-pushed
the
prebuilt-module-gen
branch
from
2e34250 to
037aede
Compare
nkcsgexi
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of swift_build_sdk_interfaces.py using
libSwiftDriver. The tool is used to traverse an entire SDK to find
Swift interface files and to generate prebuilt module cache for each one
of them. Comparing to the python implementation, this implementation generates
the prebuilt modules in the dependency order so that:
(1) It's more performant than the python counterpart. Several preliminary
experiments showed an average of 40% less CPU time spent on generating modules in an SDK.
(2) It fails fast. If an interface is broken in the SDK, this new implementation
won't schedule jobs for building other modules depending on this interface. It should help us avoid
issues like rdar://76201633