Skip to content

Handle LLVM LTO option to perform thin and full link-time-optimization #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2020
Merged

Handle LLVM LTO option to perform thin and full link-time-optimization #269

merged 3 commits into from
Sep 24, 2020

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Sep 23, 2020 •
edited
Loading

Port frontend changes for LTO from swiftlang/swift#32430

CC: @DougGregor

owenv
owenv reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty reasonable to me, just added a couple minor comments and it looks like there's a merge conflict that needs to be resolved. Thanks for porting this!

@kateinoigakukun
Copy link
Member Author

@owenv Thank you for your review! I addressed your comments 👍

artemcm
artemcm approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you @kateinoigakukun.

CC @steveapple, this PR and relevant portions of swiftlang/swift#32430 might be of interest to: #252

owenv
owenv approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@owenv
Copy link
Contributor

owenv commented Sep 24, 2020

@swift-ci test

@owenv
Copy link
Contributor

owenv commented Sep 24, 2020 

error: 'lto' is inaccessible due to 'internal' protection level
21:22:54     XCTAssertEqual(try Driver(args: ["swiftc"]).lto, nil)

@kateinoigakukun I didn't notice the lto property is used in one of the tests, sorry about that! If it's changed to @_spi(Testing) public everything should work.

@kateinoigakukun
Copy link
Member Author

@owensd Thanks for teaching me!

@owenv
Copy link
Contributor

owenv commented Sep 24, 2020

@swift-ci test

1 similar comment
@owenv
Copy link
Contributor

owenv commented Sep 24, 2020

@swift-ci test

@owenv owenv merged commit a04d98e into swiftlang:main Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kateinoigakukun @owenv @artemcm