Skip to content

Add a lit feature for the c++ driver #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Add a lit feature for the c++ driver #259

merged 1 commit into from
Sep 17, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Sep 16, 2020 •
edited
Loading

Counterpart to swiftlang/swift#33961 which has the context.

This PR passes the swift_driver parameter to lit so that it disables the integrated_driver feature.

@owenv
Copy link
Contributor Author

owenv commented Sep 16, 2020

@swift-ci test

DougGregor
DougGregor approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here LGTM, but please see my terminology comment on the Swift compiler-side change

@owenv owenv changed the title Add a lit feature for the integrated driver Add a lit feature for the c++ driver Sep 16, 2020
@owenv owenv merged commit 9081a08 into swiftlang:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenv @DougGregor