Allow linking _Concurrency for WASI with Embedded Swift
#1863
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@kateinoigakukun friendly ping |
kateinoigakukun
approved these changes
Apr 7, 2025
MaxDesiatov
added a commit
that referenced
this pull request
Apr 8, 2025
Currently, when building packages for WASI with Embedded Swift, libraries such as `libswift_Concurrency.a` and `libswift_ConcurrencyDefaultExecutor.a` are not discoverable and require passing `-Xlinker <swift-sdk-path>/usr/lib/swift/embedded/wasm32-unknown-wasip1` option manually. This path can be inferred by the driver, which simplifies build invocations for users significantly, while the rest of linkage options (`-lswift_Concurrency` etc) can be specified in toolset files.
MaxDesiatov
added a commit
that referenced
this pull request
Apr 11, 2025
Cherry-pick of #1863. **Explanation**: Currently, when building packages for WASI with Embedded Swift, libraries such as `libswift_Concurrency.a` and `libswift_ConcurrencyDefaultExecutor.a` are not discoverable and require passing `-Xlinker <swift-sdk-path>/usr/lib/swift/embedded/wasm32-unknown-wasip1` option manually. This path can be inferred by the driver, which simplifies build invocations for users significantly, while the rest of linkage options (`-lswift_Concurrency` etc) can be specified in toolset files. **Scope**: Limited to Embedded Swift for Wasm. **Risk**: Low due to limited scope. **Testing**: Added new automated test cases. **Issue**: rdar://148820885 **Reviewer**: @kateinoigakukun
MaxDesiatov
added a commit
that referenced
this pull request
Jun 2, 2025
Cherry-pick of #1863. **Explanation**: Currently, when building packages for WASI with Embedded Swift, libraries such as `libswift_Concurrency.a` and `libswift_ConcurrencyDefaultExecutor.a` are not discoverable and require passing `-Xlinker <swift-sdk-path>/usr/lib/swift/embedded/wasm32-unknown-wasip1` option manually. This path can be inferred by the driver, which simplifies build invocations for users significantly, while the rest of linkage options (`-lswift_Concurrency` etc) can be specified in toolset files. **Scope**: Limited to Embedded Swift for Wasm. **Risk**: Low due to limited scope. **Testing**: Added new automated test cases. **Issue**: rdar://148820885 **Reviewer**: @kateinoigakukun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when building packages for WASI with Embedded Swift, libraries such as
libswift_Concurrency.aandlibswift_ConcurrencyDefaultExecutor.aare not discoverable and require passing-Xlinker <swift-sdk-path>/usr/lib/swift/embedded/wasm32-unknown-wasip1option manually. This path can be inferred by the driver, which simplifies build invocations for users significantly, while the rest of linkage options (-lswift_Concurrencyetc) can be specified in toolset files.