[6.0 🍒][PrebuiltModuleGen] Ensure the dependency scanner always ignores existing prebuilt modules #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting prebuilt modules
|
@swift-ci test |
DougGregor
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: As an unintended consequence of [ScanDependency] Move binary module validation into scanner swift#72291, this tool has now started to occasionally pick up binary modules from a prebuilt cache, instead of always building new ones from their textual interface. This change uses the new control to force the tool to always build modules from interface when one is available.
Scope: This change affects the
swift-build-sdk-interfacestool and forces it to always rebuild modules from interface, instead of potentially being able to pick-up a prebuilt existing binary module.Risk: Low. This change is purely additive to force the dependency scanner to the expected behavior for this tool when the underlying compiler supports it.
Original PR: [PrebuiltModuleGen] Ensure the dependency scanner always ignores existing prebuilt modules #1651
Reviewers: @cachemeifyoucan