[6.0] Prefer toolchain's plugins to SDK plugins if the toolchain has stdlib #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, when using a OSS toolchain, which contains the stdlib in the resource directory, we should use toolchain's SwiftMacros plugin instead of the platform's one.
|
@swift-ci please test |
ktoso
changed the title
DougGregor
approved these changes
May 2, 2024
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: For example, when using a swift.org toolchain, which contains the stdlib in the resource directory, we should use toolchain's SwiftMacros plugin instead of the platform's one. This is necessary because
@TaskLocalnow have become macros, and other projects within swift project must be using it (and thus be able to find the macro).Scope/Impact:
Risk: Low
Testing: CI testing and @rintaro manually verified
Reviewed by: @ktoso (making cherry-pick on behalf of @rintaro who did the PR)
Original PR: #1590