Support for binary module validation in scanner #1563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
rintaro,
xymus,
benlangmuir,
artemcm and
tshortli
|
This is to support the change in swiftlang/swift#72291 |
|
@swift-ci please test |
Fix all the tests that expect building module from interface even when the binary module is up-to-date after the swift scanner behavior change.
cachemeifyoucan
force-pushed
the
eng/PR-123711823
branch
from
44299e6 to
4864513
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
ping @artemcm This is needed to allow the swift change to pass PR. Should have no functional changes except added the new flag option and use that to update the test so test can pass with or without the change. |
artemcm
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the tests that expect building module from interface even when the binary module is up-to-date after the swift scanner behavior change.