[Caching] Remap the path in -file-compilation-dir if needed
#1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-up to swiftlang#1557 that when caching is enabled and using the scanner prefix mapping option to canonicalize the path, make sure the path passed via `-file-compilation-dir` is remapped.
Contributor
Author
|
@swift-ci please test |
Contributor
|
Is the scanner prefix mapping separate from the debug info prefix mapping? If not, it might be more consistent the have IRGenDebugInfo apply the mapping. |
Contributor
|
Otherwise this LGTM |
Contributor
Author
scannerPrefixMapping remaps all input source files so the rest of swift compiler will not even see the original path at all. It works on the CAS file system level to canonicalize path, so debug info remap should not be used in caching builds (same for clang). This patch is to remap the path on the command-line, so all paths are consistent in this new remapped file system. |
artemcm
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #1557 that when caching is enabled and using the scanner prefix mapping option to canonicalize the path, make sure the path passed via
-file-compilation-diris remapped.