Skip to content

[Caching] Fix caching tests on windows hosts #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cachemeifyoucan
Copy link
Contributor

For Windows host, the on-disk CAS is not yet enabled in libSwiftScan yet (due to the lack of support for Windows path in cached file system abstraction), so report caching is not supported on windows hosts.

For Windows host, the on-disk CAS is not yet enabled in libSwiftScan yet
(due to the lack of support for Windows path in cached file system
abstraction), so report caching is not supported on windows hosts.
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but insufficient. There are a number of tests that are still failing with this change.

@cachemeifyoucan cachemeifyoucan merged commit 45555b1 into swiftlang:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants