[5.9 🍒][Explicit Modules] Handle re-mapped platform versions when specifying SDK-aligned -clang-target on Darwin platforms
#1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK-aligned `-clang-target` on Darwin platforms Resolves rdar://108288193
|
@swift-ci test |
xymus
approved these changes
Jul 6, 2023
nkcsgexi
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1394
• Release: 5.9
• Explanation: #1322 introduced functionality to the driver where
-clang-targetfor all Clang module dependencies is set to the target SDK deployment target on Darwin platforms. The original implementation missed the case of targeting platforms with an SDK-specified OS version re-map, causing incorrect versions to be used in those cases, in Explicit Module Builds.• Reviewed by: @xymus
• Scope of Issue: Explicitly-built module dependencies of builds targeting platforms with a version remap (e.g. MacCatalyst) use incorrect/unexpected target OS versions for Clang module dependencies.
• Risk: Low. This change modifies code that does not run on default (Implicit Modules) compilation code-path, and the change itself is straight-forward and small, for affected code-paths.
• Testing: Automated tests added to the driver test suite.
Resolves rdar://108288193