Skip to content

update argument parser to 1.2.x #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2023
Merged

update argument parser to 1.2.x #1285

merged 2 commits into from
Feb 13, 2023

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Feb 8, 2023

No description provided.

compnerd
compnerd reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the other users of s-a-p as well and swift-installer-scripts. Windows uses a dynamically linked copy of s-a-p that is shared across the driver, SPM, and LSP.

@tomerd tomerd mentioned this pull request Feb 8, 2023
Merged
@tomerd
Copy link
Contributor Author

tomerd commented Feb 8, 2023

swiftlang/swift#63521
swiftlang/swift-package-manager#6131
swiftlang/sourcekit-lsp#708

@swift-ci test

@artemcm
Copy link
Contributor

artemcm commented Feb 8, 2023

@tomerd there is no cross-repo testing from here, unfortunately.
You'll need to run it from the main Swift repo and include all of the above plus this PR.

@allevato
Copy link
Member

allevato commented Feb 8, 2023

@compnerd Does swift-format also need to be updated here?

@tomerd
Copy link
Contributor Author

tomerd commented Feb 8, 2023

@artemcm swiftlang/swift#63521

This was referenced Feb 8, 2023
Merged
Merged
@compnerd
Copy link
Member

compnerd commented Feb 8, 2023

@allevato yes 🙈

@tomerd
Copy link
Contributor Author

tomerd commented Feb 10, 2023

swiftlang/swift#63521
swiftlang/swift-package-manager#6131
swiftlang/sourcekit-lsp#708

@swift-ci test

@shahmishal shahmishal merged commit b72c1f0 into swiftlang:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomerd @artemcm @allevato @compnerd @shahmishal