[Dependency Scanning] Move computation of the path for libSwiftScan to the toolchain #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
artemcm
force-pushed
the
RefactorLibSwiftScanLookup
branch
from
1972c29 to
eaf6051
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
RefactorLibSwiftScanLookup
branch
from
eaf6051 to
42490ce
Compare
artemcm
commented
Jan 11, 2023
| // FIXME: This can be subtly wrong, we should rather | ||
| // try to get the client to provide this info or move to a better | ||
| // path convention for where we keep compiler support libraries | ||
| internal var compilerHostSupportLibraryOSComponent : String { |
Contributor
Author
There was a problem hiding this comment.
I am hoping to be able to get rid of this once swiftlang/swift#62972 becomes the norm. But in the meantime it is just here to handle the soon-to-be legacy path.
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
RefactorLibSwiftScanLookup
branch
2 times, most recently
from
4486b10 to
8bb4075
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
…o the toolchain Alongside lookup of executable tools, the toolchain is now responsible for looking up the driver's compiler support and dependency scanning library. It also adds an environment variable override 'SWIFT_DRIVER_SWIFTSCAN_LIB' for clients to specify a specific path to this shared library that they would like to be used instead of the default.
artemcm
force-pushed
the
RefactorLibSwiftScanLookup
branch
from
8bb4075 to
3982378
Compare
Contributor
Author
|
@swift-ci test |
This was referenced Jan 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alongside lookup of executable tools, the toolchain is now responsible for looking up the driver's compiler support and dependency scanning library.
It also adds an environment variable override 'SWIFT_DRIVER_SWIFTSCAN_LIB' for clients to specify a specific path to this shared library that they would like to be used instead of the default.