Reinstate "Use Swift 5.7 base image for Swift CI jobs to support bootstrapping" #341
Conversation
|
@swift-ci please test |
| @@ -1,8 +1,8 @@ | |||
| FROM amazonlinux:2 | |||
| FROM swift:5.7-amazonlinux2 | |||
There was a problem hiding this comment.
should this be pinned to 5.7 or use the latest release?
There was a problem hiding this comment.
Pinned makes sense to me given that we support releases up to 12 months back. So 5.7/5.8/.5.9. Though ideally we'd have a build for 5.8 + 5.9 going as well.
|
|
||
| ENV PATH="${PATH}:/opt/swift/usr/bin" | ||
|
|
||
| RUN swift --version |
There was a problem hiding this comment.
this is a surprising change. why do we need to do this? should we fix the docker image instead if this is fixing something?
There was a problem hiding this comment.
Ideally all our release images would install into /opt/swift/<version> instead of /usr. But we don't want to break current clients, so for now we're just updating the builder image.
Without this change, Swift uses the toolchain-clang to build and then uses the system C++ stdlib instead of devtoolset as it should. The system stdlib is wildly out of date (unsurprising) and thus doesn't have any new C++ features.
@shahmishal given all the other images are using the toolchain clang, perhaps we should make this ENV PATH=/opt/swift/usr/bin:${PATH} instead of appending?
There was a problem hiding this comment.
@shahmishal given all the other images are using the toolchain clang, perhaps we should make this ENV PATH=/opt/swift/usr/bin:${PATH} instead of appending?
Yes, that make sense.
There was a problem hiding this comment.
this is a surprising change. why do we need to do this? should we fix the docker image instead if this is fixing something?
We can change this in 5.9 release, if the community is ok with the change. I would like to avoid this type of change in dot release.
this is where I was going with my questions. I think we should fix this going forward |
|
Yep, using
It gives us a lot more flexibility for how we want to distribute things. |
|
fwiw, not all distributions like things in /opt so this may need to be refined per distribution, but 100% with the approach and we should def fix it in the toolchain packaging itself since its more correct |
|
I've updated to use a downloaded toolchain rather than the base image for all Linux platforms - #346. Made a new PR since I wanted to rebase + squash. |
With swiftlang/swift#66199, we're close(r) to the point where we can build the Swift compiler that integrates Swift code built using the host Swift.