[6.0] Handle various out-of-bounds diagnostic ranges in default diagnostics formatter (#947) #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-ronnqvist
commented
Jun 11, 2024
d-ronnqvist
commented
- Explanation: This adds additional input validation in the default diagnostic formatter, instead of trusting that the diagnostic source range is correct.
- Scope: Potential crashes for diagnostics that have out-of-bounds source ranges due to other bugs.
- Issue: rdar://129586253 Duplicated diagnostic causing crash on DefaultDiagnosticConsoleFormatter #729
- Risk: Low
- Testing: New tests verify that incorrectly created diagnostics with out-of-bounds source ranges are handled by the default diagnostic formatter.
- Reviewer: @Kyle-Ye
- Original PR: Handle various out-of-bounds diagnostic ranges in default diagnostics formatter #947
… formatter (swiftlang#947) * Clamp lines to highlight in a diagnostic to the source lines * Add test about highlight for in-bounds range of a line * Clamp diagnostic line highlight to the bounds of each source line rdar://129586253
|
@swift-ci please test |
franklinsch
approved these changes
Jun 12, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.