[5.6] Adapt tests to work better in Swift CI (#45) #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add utility to create temp directories in unit tests * Create new target for test utilities * Pass the temporary directory to ConvertAction * Re-enable one skipped test * Update new tests to use `createTemporaryDirectory` helper * Remove `createDirectoryForLastPathComponent` argument in test helper * Update test helper documentation * Prefer `FileManager.temporaryDirectory` property in ConvertAction * Move `Files` and `Folder` types into test utility target * Add additional safety checks when creating and removing temporary directories * Replace `TempFolder` test class with `createTempFolder` test function * Use XCTUnwrap instead of force unwrap in test helper * Also shadow `FileManager.temporaryDirectory` in tests * Add temp directory test helper variant with "named" argument This is clearer at the call site when only a single path component is specified. * Fix test helper syntax in disabled preview server test * Re-enable one file monitoring test
|
I'll close this and open a new PR with a better branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainandrelease/5.6it increases the chance that a commit frommainthat's cherry picked onto 5.6 has a conflict in the unit testing code.