Update build script helper to use python3 #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python2 is no longer supported by the Swift project.
`output_dir` is written to but never used.
|
@swift-ci please test |
|
Running a test toolchain build with these changes here: |
shahmishal
approved these changes
Jun 2, 2022
shahmishal
pushed a commit
that referenced
this pull request
Aug 30, 2022
* Use `python3` in build-script-helper Python2 is no longer supported by the Swift project. * Remove unused variable from build script `output_dir` is written to but never used. (cherry picked from commit 41f116f)
ethan-kusters
added a commit
that referenced
this pull request
Aug 30, 2022
* Use `python3` in build-script-helper Python2 is no longer supported by the Swift project. * Remove unused variable from build script `output_dir` is written to but never used. (cherry picked from commit 41f116f) Co-authored-by: Ethan Kusters <ekusters@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: #272
Summary
Python 2 is no longer supported by the Swift project. This updates the build script helper to use python3.
Testing
Confirm that toolchains continue to build on all platforms with the change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
Added tests./bin/testscript and it succeeded