[SE-0046] Implemented consistent function labels #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Thanks for making these changes @harlanhaskins. For reference, the compiler work connected to this is happening in swiftlang/swift#2047 Depending on how quickly you're hoping to get this all in, it may make sense to wait on this until #86 and/or #88 get merged, which I expect to happen very soon. |
|
I wouldn't mind merging #86 and #88 tonight. @harlanhaskins, are you capable of triggering Apple CI? 😉 |
|
This generally looks good to me. We should at least preserve the current API until we're ready to have the discussion of what other changes may be warranted (in both XCTests) for Swift 3. |
|
@swift-ci please test |
|
CI is going to fail for this as the parse changes haven't landed in the compiler. |
harlanhaskins
force-pushed
the
se-0046-consistent-func-labels
branch
from
9d6875c to
f935137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes specified in SE-0046 Establish consistent label behavior across all parameters including first labels