Don't call a notification expectation handler after the expectation has expired #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a notification expectation fails, either due to a
waitForExpectationsWithTimeout
call or because the test ends, the internal notification observer could still end up calling the expectation handler if the expected notification is fired at a later point. With this change, the notification observer weakly captures the expectation, and won't do any work if the notification is observed but the expectation isn't around anymore.