-
Notifications
You must be signed in to change notification settings - Fork 263
Use swiftc for linking. #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
Hmm. Looks like the |
@parkera OK to merge? |
@swiftix Swift CI should have been enabled 13 days ago: #45 (comment). swiftlang/swift#1316 adds support for tests. |
This change looks fine. I'm curious, how did you test this change locally? Did you try running the tests?
|
I tested it as a part of a Swift build process, which included testing this project as well. |
@modocache As for Swift CI. It has been started by my comment. But it fails instantly because of some git issues or something like that. So essentially Swift CI for this project is broken at the moment, which prevents it from testing new PRs. |
@modocache More details are available if you look at the Swift CI logs. |
@swiftix Thanks! Just to clarify: the tests for this project aren't run as part of any Swift |
I think the change is fine. But I normally do not touch |
@modocache I have my our build-script preset that I used for that. |
I also tested using the command you provided above. No test failures. |
@swiftix Awesome!! Thanks so much. If I had commit access, I'd merge this in a heartbeat. @mike-ferris-apple is the main steward of this project but is away for the week. It would be great if @parkera or @gribozavr could merge. 🙇 |
Using
swiftc
for linking is more reliable. It also properly handles auto-linking.