Skip to content

Use swiftc for linking. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

swiftix
Copy link
Contributor

@swiftix swiftix commented Feb 22, 2016

Using swiftc for linking is more reliable. It also properly handles auto-linking.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

@swift-ci Please test

swiftix referenced this pull request Feb 22, 2016
Fixes to enable swift section objects
@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

Hmm. Looks like the swift-ci trick is not supported for this project ;-(

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

@parkera OK to merge?

@modocache
Copy link
Contributor

@swiftix Swift CI should have been enabled 13 days ago: #45 (comment). swiftlang/swift#1316 adds support for tests.

@modocache
Copy link
Contributor

This change looks fine. I'm curious, how did you test this change locally? Did you try running the tests?

./build_script.py \
    --swiftc="/swift/usr/bin/swiftc" \
    --build-dir="/tmp/XCTest_build" \
    --swift-build-dir="/swift/usr" \
    --arch="x86_64" \
    --test

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

I tested it as a part of a Swift build process, which included testing this project as well.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

@modocache As for Swift CI. It has been started by my comment. But it fails instantly because of some git issues or something like that. So essentially Swift CI for this project is broken at the moment, which prevents it from testing new PRs.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

@modocache More details are available if you look at the Swift CI logs.

@modocache
Copy link
Contributor

@swiftix Thanks! Just to clarify: the tests for this project aren't run as part of any Swift utils/build-script invocation--at least, they won't be until swiftlang/swift#1316 is merged.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

I think the change is fine. But I normally do not touch swift-corelibs-xctest. This is why I want someone more familiar with this project to click the Merge button.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

@modocache I have my our build-script preset that I used for that.

@swiftix
Copy link
Contributor Author

swiftix commented Feb 22, 2016

I also tested using the command you provided above. No test failures.

@modocache
Copy link
Contributor

@swiftix Awesome!! Thanks so much. If I had commit access, I'd merge this in a heartbeat. @mike-ferris-apple is the main steward of this project but is away for the week. It would be great if @parkera or @gribozavr could merge. 🙇

mike-ferris pushed a commit that referenced this pull request Feb 22, 2016
@mike-ferris mike-ferris merged commit 8af59ab into swiftlang:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants