[build_script.py] Remove redundant argparse params #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For options `like-this`, `argparse` stores the variable name `like_this`. Remove redundant `dest` parameters in the build script. - For options marked as "store", `argparse` stores `None` when the option is not specified. Remove redudnant `default=None` parameters in the build script. - For options marked as "store_true", the default value is `False`. Remove redundant `default=True` parameters in the build script. - The default action for options is "store". Remove redundant `action="store"` parameters in the build script. - `argparse` raw formatters only really make sense when used with multi-line strings that have custom indentation. It's not necessary in the build script. - `--arch` option is required.
modocache
force-pushed
the
build-script-redundancies
branch
from
e2e218f to
3072710
Compare
|
Looks like a good simplification. Thanks! |
mike-ferris
pushed a commit
that referenced
this pull request
Feb 22, 2016
[build_script.py] Remove redundant argparse params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like-this,argparsestores the variable namelike_this. Remove redundantdestparameters in the build script.argparsestoresNonewhen the option is not specified. Remove redundantdefault=Noneparameters in the build script.False. Remove redundantdefault=Trueparameters in the build script.action="store"parameters in the build script.argparseraw formatters only really make sense when used with multi-line strings that have custom indentation. It's not necessary in the build script.--archoption is required.